Added GNB Lv40, Lv50, L60, L70 support #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were certain bugs within the code that were causing Autorotation to brick in plenty of instances regarding Lv40-Lv72. This is a fix for that. I added support for lower levels, preferably Lv40-70 - Lv40: Added logic to make sure ST and AOE combo works effectively the same as Lv50 combo. - Lv50: Added logic to ensure the appropriate skills are being used for the correct rotation. No Mercy was not being procced on ST or AOE & when you used it manually, it would get stuck. Added a couple !state checks to ensure no funny business with locked skills due to level sync. (fuck off Gnashing Fang) - Lv60: Fixed AOE combo issue; Kept getting stuck on Fated Circle, so added a !state check for appropriate skills to ensure Burst Strike (or Gnashing Fang) is used, regardless of ST or AOE. - Lv70: basically same shit as Lv60.
yada yada
This reverts commit c0bc567.
|
I'm not sure why these keep failing the build checks, as I am only within GNBRotation.cs, however if there's something I am missing within the framework please lmk. |
you can click on the details of the failed check to see which changes need to be made |
Akechi-kun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were certain bugs within the code that were causing Autorotation to brick in plenty of instances regarding Lv40-Lv72.
This is a fix for that.
I added support for lower levels, preferably Lv40-70